Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !839

Change OSX framework bundle paths

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/robbertvanginkel/osx_frameworkpaths into master Aug 10, 2016
  • Overview 8
  • Commits 1
  • Pipelines 0
  • Changes 4

Created by: robbertvanginkel

I don't know where the Contents and MacOs folders originally came from, that commit (d44f10e6) doesn't contain a lot of background. I think those folders are wrong for the following reasons:

  • They do not conform to the apple docs
  • Checking a random library on my mac also doesn't show them.
$ tree -L 3 /Library/Frameworks/iTunesLibrary.framework
/Library/Frameworks/iTunesLibrary.framework
├── Headers -> Versions/Current/Headers
├── Modules -> Versions/Current/Modules
├── Resources -> Versions/Current/Resources
├── Versions
│   ├── A
│   │   ├── Headers
│   │   └── iTunesLibrary
│   └── Current -> A
└── iTunesLibrary -> Versions/Current/iTunesLibrary
  • When using a framework generated from an apple_library (I know this doesn't fully work but I'm working on a PR to fix that), clang complains during linking/preprocessing (with -F and -framework) that it cannot find the framework. When I changed the binaries and headers to not be in the contents and MacOS paths everything works.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/robbertvanginkel/osx_frameworkpaths