Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !923

Make swift compiler honor min target sdk version

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/nguyentruongtho/tho/honor_target_sdk into master Oct 06, 2016
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: nguyentruongtho

Previously, swift uses version of the sdk it is compiling with as the minimum target version for deployment.

This causes the issue when you compile swift target with newer sdk, the resulting app will crash on the old target event if you specify correct target deployment in buckconfig, for example:

[apple]
  iphonesimulator_target_sdk_version = <old_sdk_version>
  iphoneos_target_sdk_version = <old_sdk_version>

This PR make swift compiler honor *_target_sdk_version settings.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/nguyentruongtho/tho/honor_target_sdk