Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !930

Use realpath instead of readlink in binary wrappers

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/aarongable/master into master Oct 10, 2016
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: aarongable

Readlink directly returns the target of a symlink. If the symlink is relative, readlink only returns the relative path. This path is relative to the buck executable on $PATH, not to the current working directory, so the Python invocation fails.

Using realpath instead directly resolves the full absolute path referred to by the symlink, allowing users to use relative symlinks in their bin/ directory on $PATH.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/aarongable/master