Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !935

Fix silent buckd failure on openpty

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/azhao12345/fix-openpty-crash into master Oct 11, 2016
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: andrewzhaosc

throws LastErrorException will throw whenever errno is nonzero, but the value of errno is undefined unless the function otherwise indicates an error.

In certain situations, the system does in fact set errno to a nonzero value while still returning a success result. In this case, an exception will be thrown and buckd will fail to start.

This change properly checks the success of the system calls by looking at the return value as specified by the standard.

fixes #931 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/azhao12345/fix-openpty-crash