Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #11119
Closed
Open
Issue created Jun 17, 2021 by Administrator@rootContributor

document SKIP_PREFLIGHT_CHECK, improve err messaging

Created by: eckdanny

Is your proposal related to a problem?

Unclear that PREFLIGHT_CHECK consists only of verifyPackageTree. CRA users in non-traditional environments (e.g.; git submodules, lerna, yarn workspaces) encountering this can get a false positive because normal node module resolution indeed works just fine.

refs:

  • #1333
  • #6756
  • #1795 (closed)

Describe the solution you'd like

  1. Wordsmith the error messaging in verifyPackageTree.js to indicate this is only a footgun check
  2. Add something to the docs site about this flag. AFAIK, there is no mention of SKIP_PREFLIGHT_CHECK anywhere in the docs site, but adding to /docusaurus/docs/advanced-configuration.md at minimum would be a good idea.

Describe alternatives you've considered

Would be nice if the SKIP_PREFLIGHT_CHECK had a more descriptive name, but not worth changing IMO.

Assignee
Assign to
Time tracking