Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #1746
Closed
Open
Issue created Mar 07, 2017 by Administrator@rootContributor

Use React-provided stacktrace in crash overlay

Created by: Timer

The recently merged crash overlay should support whitelisted warnings thrown by React.

Currently, this can be accomplished by enabling the console proxy via:

proxyConsole('error');

However, this relies on a synthetically generated stack-trace and not the stack-trace provided by React in the warning. e.g.

    var error = void 0;
    try {
      throw new Error(message);
    } catch (e) {
      error = e;
    }

This is problematic, however, because of how React works.

In React, components aren't rendered recursively, so there's never more than one component's render() on the stack - @gaearon

This results in an unreconstructed tree of components specifying where the problem is stemming from.


The stack-trace from React is actually already parsed, and used to replace the line references on the synthetically generated stack-trace.

The proper behavior, however, would be to not generate a synthetic stack-trace and rely solely on the stack-trace given by React.

We realize this may be a daunting issue, but if you are up to the challenge, we will answer your every question!

Assignee
Assign to
Time tracking