Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #2339
Closed
Open
Issue created May 23, 2017 by Administrator@rootContributor

doesn't respect .eslintignore

Created by: oriSomething

Can you reproduce the problem with latest npm?

yes

Description

create-react-app 1.x doesn't respect .eslintignore. (It was use to respect it on version 0.9.x).

Expected behavior

Not showing ESLint warning/errors of files in the .eslintignore file

Actual behavior

See warning such as:

Compiled with warnings.

./src/vendor/modernizr.js
  Line 25:   Shadowing of global property 'undefined'     no-shadow-restricted-names
  Line 163:  Do not use Boolean as a constructor          no-new-wrappers
  Line 431:  Unexpected string concatenation of literals  no-useless-concat
  Line 436:  Expected '===' and instead saw '=='          eqeqeq

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

Environment

Run these commands in the project folder and fill in their results:

  1. npm ls react-scripts (if you haven’t ejected): react-scripts@1.0.5
  2. node -v: v6.10.0
  3. yarn -v: v0.24.5

Then, specify:

  1. Operating system: OSX Sierra
  2. Browser and version: *

Reproducible Demo

.eslintignore :

vendor/*.js
src/vendor/*.js
src/vendor/vendor.js

src/vendor.js:

(function(undefined) {
  var a = 1;
  var b = a == 1;
  window.$someProp$ = b;
}());

src/index.js:

import "./vendor/vendor.js";
Assignee
Assign to
Time tracking