Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #2357
Closed
Open
Issue created 8 years ago by Administrator@rootContributor
  • New related issue

  • Report abuse to administrator

  • New related issue

  • Report abuse to administrator

FileSizeReporter reports with wrong (hardcoded) path.

Closed

FileSizeReporter reports with wrong (hardcoded) path.

Created by: fezhengjin

Can you reproduce the problem with latest npm?

yes

Description

When i changed the value of appBuild property to dist in "react-scripts/config/paths.js" and run npm run build, the printFileSizesAfterBuild function logged wrong paths.

Expected behavior

Log in the console should be like:

File sizes after gzip:

  16.13 KB  dist/static/js/main.3a5b25c4.js
  5.72 KB   dist/static/css/main.dc21d15c.css

Actual behavior

But it still reported with "build" in paths:

File sizes after gzip:

  16.13 KB  build/static/js/main.3a5b25c4.js
  5.72 KB   build/static/css/main.dc21d15c.css

Environment

Run these commands in the project folder and fill in their results:

  1. npm ls react-scripts (if you haven’t ejected):
  2. node -v: v7.4.0
  3. npm -v: 4.0.5

Then, specify:

  1. Operating system: macOS Sierra 10.12.4
  2. Browser and version:

Hardcode

https://github.com/facebookincubator/create-react-app/blob/master/packages/react-dev-utils/FileSizeReporter.js#L33

  1. Oh no!

    You are trying to upload something other than an image. Please upload a .png, .jpg, .jpeg, .gif, .bmp, .tiff or .ico.

    Incoming!

    Drop your designs to start your upload.
Tasks
0

No tasks are currently assigned. Use tasks to break down this issue into smaller parts.

Linked items
0

Link issues together to show that they're related. Learn more.

Activity


Please register or sign in to reply
0 Assignees
None
Assign to
Labels
3
contributions: claimed difficulty: starter issue: bug
3
contributions: claimed difficulty: starter issue: bug
    Assign labels
  • Manage project labels

Milestone
No milestone
None
Due date
None
None
None
Time tracking
No estimate or time spent
Confidentiality
Not confidential
Not confidential

You are going to turn on confidentiality. Only project members with at least the Reporter role, the author, and assignees can view or be notified about this issue.

Lock issue
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app#2357

Menu

Explore Projects Groups Snippets