Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #2750
Closed
Open
Issue created Jul 08, 2017 by Administrator@rootContributor

Conditionally output serve instructions

Created by: evenstensberg

Is this a bug report?

No, Enhancement Request

Summary

If you've got serve already installed globally, asking users to install it becomes redundant.

Example:

skjermbilde 2017-07-08 kl 21 08 23

Current Implementation

Current implementation is that the same instruction gets outputted, even though you'd have serve installed after running yarn build

Proposed

  1. Check global prefix and where the users global folder is installed
  2. Print stdout message if it doesn't exist

Use process.argv to map back to where the global folder is, or you could add global-prefix as a dependency.

https://github.com/facebookincubator/create-react-app/blob/a171d930641f513279b1c7ceaab1fa9bbbbbb896/packages/react-dev-utils/printHostingInstructions.js#L124-L131


Happy hacking :)

Assignee
Assign to
Time tracking