Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #3096
Closed
Open
Issue created Sep 08, 2017 by Administrator@rootContributor

Runtime error overlay does not disappear when fixed with HMR

Created by: eirikurn

Is this a bug report?

Yes

Can you also reproduce the problem with npm 4.x?

Yes

Which terms did you search for in User Guide?

Hot module replacement. Error overlay.

Environment

  1. node -v: 8.1.4
  2. npm -v: 5.3.0
  3. yarn --version: 1.0.1
  4. npm ls react-scripts: 1.0.13

Then, specify:

  1. Operating system: macOS 10.12.6
  2. Browser and version (if relevant): Chrome 60

Steps to Reproduce

  1. Add hot module reloading by accepting hot changes in src/index.js which re-renders the React app.
  2. Add a runtime exception in some React components. (throw new Error()).
  3. Open app to see the error overlay.
  4. Fix the error in your React component.
  5. Wait for webpack to rebuild and look at the app.

Expected Behavior

The error overlay should disappear.

Actual Behavior

The error overlay stays in view. If I close the overlay, I can see the new state of the app, properly fixed.

Assignee
Assign to
Time tracking