Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #3573
Closed
Open
Issue created Dec 09, 2017 by Administrator@rootContributor

Extend --scripts-version to support more formats

Created by: SaschaDens

For a project I want to use a custom react-scripts to provide additional tasks for code compilation. Here I wanted to make use --scripts-version with a default generated .tar.gz file from GitLab.

But --scripts-version only looks for the .tgz extension and therefor the command fails. I was initially confused by the following line createReactApp.js#L374 but after digging in the code I found that there is only a check done for .tgz.

I can create a PR for this to further extend the checks done at createReactApp.js#L419 to also look for .tar and .tar.gz formats as the package that's used to extract the content also supports these formats (tar-pack), and also extend the documentation and console output as documentation is currently limited for --scripts-version (GIT is apparently also supported).

Would it make sense?

Assignee
Assign to
Time tracking