Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #4325
Closed
Open
Issue created Apr 19, 2018 by Administrator@rootContributor

theme-color meta tag is inconsistent with manifest's theme-color

Created by: fang0rnz

Is this a bug report?

Yes

Did you try recovering your dependencies?

Yep

Which terms did you search for in User Guide?

(Write your answer here if relevant.)

Environment

  1. node -v: 9.11.1
  2. npm -v: 5.6.0
  3. yarn --version (if you use Yarn): 1.5.1
  4. npm ls react-scripts (if you haven’t ejected): 1.1.4

Then, specify:

  1. Operating system: Windows 10 x64
  2. Browser and version (if relevant): not relevant

Steps to Reproduce

  1. npx create-react-app my-app
  2. cd my-app
  3. Change theme-color on manifest.json to anything but the default
  4. yarn build
  5. check that built html has a meta tag specifying theme-color, it overrides what is specified on package.json:

Expected Behavior

built html should'nt have the default #000000 meta tag or it should match what you edited on manifest.json

Actual Behavior

Colors don't match. Mobile chrome's screen is still black and the added PWA also.

image

image

https://developers.google.com/web/updates/2015/08/using-manifest-to-set-sitewide-theme-color "If you page already has a theme-color meta tag — for example — then the page level configuration will be used instead of the value in the manifest."

Reproducible Demo

It's not necessary, just create a new app and you will see this happening.

Assignee
Assign to
Time tracking