Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #465
Closed
Open
Issue created Aug 20, 2016 by Administrator@rootContributor

[Discussion] Deactivating new-cap rule (Immutable.js user)

Created by: rricard

Hello!

I just tried out create-react app and it's pretty cool! However, I'm an heavy user of Immutable and the eslint new-cap rule does not behave well with it (activated by default).

For now, I'm deactivating the rule on a per-file basis so that's not such a big issue! But I can't seem to be able to deactivate it project-wide in the package.json (it actually works on my editor, but not on the dev server ...).

To tackle this issue, I see two possibilities:

  • Find a way to get the dev server reading the project's eslint configuration in package.json (that would be cool to have that working anyway! => I'll try to take a look myself 😉 if it's possible)
  • Have a discussion around the new-cap rule that isn't universally liked (and discouraged when used with immutable, I'll point to you one comment from @leebyron on this: https://github.com/eslint/eslint/issues/2023#issuecomment-80255655, not saying we should get rid of it because he said so but I'd like to see what others think about it too!)

Thank you again for this project, hope this discussion will help make it even better!

Assignee
Assign to
Time tracking