Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #4927
Closed
Open
Issue created Aug 27, 2018 by Administrator@rootContributor

File size reporter on Windows

Created by: fiddep

Is this a bug report?

Yes

Did you try recovering your dependencies?

Yes

Which terms did you search for in User Guide?

windows, build, size

Environment

Environment:
  OS:  Windows 10
  Node:  10.9.0
  Yarn:  1.9.4
  npm:  6.2.0
  Watchman:  Not Found
  Xcode:  N/A
  Android Studio:  Not Found

Packages: (wanted => installed)
  react: ^16.4.2 => 16.4.2
  react-dom: ^16.4.2 => 16.4.2
  react-scripts: 1.1.5 => 1.1.5

Steps to Reproduce

  1. create a fresh app
  2. run yarn build
  3. add stuff to any file
  4. run yarn build

Expected Behavior

the output would show that the file size has increased if a previous build was present

Actual Behavior

Nothing else except the current filesize is show Before: http://prntscr.com/kndf9p After: http://prntscr.com/kndit2

Possible Solution

The issue seems to be related to Windows and its path delimiter. Adding .replace(/\\/g, '/') in FileSizeReporter Solves the problem and don't seem to cause any issues on other OS

Would happily submit a PR for this

Assignee
Assign to
Time tracking