Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #7391
Closed
Open
Issue created Jul 19, 2019 by Administrator@rootContributor

Support @typescript-eslint/recommended

Created by: vdbongard

Is your proposal related to a problem?

The default typescript template is not compatible with the @typescript-eslint/recommended rules.

Incompatible rules:

  • @typescript-eslint/no-use-before-define
  • @typescript-eslint/explicit-function-return-type

Steps to reproduce

  1. yarn create react-app project --typescript
  2. cd project
  3. create .eslintrc.js:
module.exports = {
  extends: [
    'plugin:@typescript-eslint/recommended',
    'react-app',
  ],
};
  1. eslint '*/**/*.{ts,tsx}' --fix

2 errors, 17 warnings cannot be fixed:

  • errors: @typescript-eslint/no-use-before-define
  • warnings: @typescript-eslint/explicit-function-return-type

Describe the solution you'd like

The TypeScript template should be adjusted to be conform with the @typescript-eslint/recommended rules.

Additional infos

I can create a pull request with the changes needed.

Assignee
Assign to
Time tracking