Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #7615
Closed
Open
Issue created Aug 30, 2019 by Administrator@rootContributor

document prettier integration better

Created by: brlewis

Is your proposal related to a problem?

In Formatting Code Automatically the example uses a command-line option to configure prettier to favor single quotes. At the end it directs people to how they might configure their editor. But the editor is going to use prettier defaults, not the command with options that's part of the git hook, so the editor will keep changing to double quotes, making git diff less useful, until changes are committed and it switches back to single quotes.

Describe the solution you'd like

Plan A would be not to include any configuration in the example. This would be most concise and simple. Full disclosure this is partly because I'm personally on a "don't customize anything" kick wanting to just take the defaults on everything wherever possible.

Describe alternatives you've considered

If there's objection to removing the single-quote configuration from the example, plan B would be to add a "prettier" key to the package.json customization in the example. That way the prettier config would be where all integrations could find it.

Additional context

More discussion on prettier defaults

Assignee
Assign to
Time tracking