Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10048

Increase Workbox's maximumFileSizeToCacheInBytes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jeffposnick/patch-1 into master Nov 09, 2020
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: jeffposnick

By default, any asset that is larger than 2mb won't be precached when using Workbox in your service worker with the PWA template. This will bump up that limit to 5mb.

There's a tradeoff here—you can easily end up accidentally precaching, e.g., very large media files by mistake if this limit is too high—but based on https://github.com/cra-template/pwa/issues/13#issuecomment-722667270, it's fairly easy to hit the 2mb limit on lazy-loaded JavaScript chunks. 5mb seems like a decent compromise.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jeffposnick/patch-1