Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10052
An error occurred while fetching the assigned milestone of the selected merge_request.

docs: add React Testing Library as a library requiring jsdom

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/anyulled/patch-1 into master 4 years ago
  • Overview 5
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: anyulled

As the React Testing library requires a dom to execute their assertions, I'm adding it to the list of libraries requiring it on the documentation.

here's a screenshot of a test failing by using the node environment. image

Loading
Loading

Activity


  • Administrator requested review from @root 4 years ago

    requested review from @root

  • Administrator requested review from @root 4 years ago

    requested review from @root

  • Administrator requested review from @root 4 years ago

    requested review from @root

  • Administrator
    Administrator @root · 4 years ago
    Author Contributor

    Created by: facebook-github-bot

    Hi @anyulled!

    Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

    In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

    If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

  • Administrator
    Administrator @root · 4 years ago
    Author Contributor

    Created by: anyulled

    • Contributor License Agreement signed
  • Administrator changed title from Adding Testing library as a library requiring jsdom to Documentation: Adding Testing library as a library requiring jsdom 4 years ago

    changed title from Adding Testing library as a library requiring jsdom to Documentation: Adding Testing library as a library requiring jsdom

  • Administrator added CLA Signed label 4 years ago

    added CLA Signed label

  • Administrator
    Administrator @root · 4 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

  • Administrator changed title from Documentation: Adding Testing library as a library requiring jsdom to docs: add React Testing Library as a library requiring jsdom 4 years ago

    changed title from Documentation: Adding Testing library as a library requiring jsdom to docs: add React Testing Library as a library requiring jsdom

  • Administrator
    Administrator @root · 4 years ago
    Author Contributor

    Merged by: ianschmitz at 2020-11-10 16:49:43 UTC

  • Administrator closed 4 years ago

    closed

  • Administrator
    Administrator @root · 4 years ago
    Author Contributor

    Created by: ianschmitz

    Thanks!

  • Administrator added tag: documentation label 4 years ago

    added tag: documentation label

  • Administrator changed milestone to %4.0.1 4 years ago

    changed milestone to %4.0.1

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
3
3 participants
Administrator
William Cheng
Jim Schubert
Reference:
Source branch: github/fork/anyulled/patch-1

Menu

Explore Projects Groups Snippets