Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10091

Recovered some integration tests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/maxsbelt/fix-ci-problems into master Nov 18, 2020
  • Overview 7
  • Commits 7
  • Pipelines 0
  • Changes 8

Created by: maxsbelt

I noticed that all the latest PRs have a red cross (even merged). This PR contains several fixes that recover some of integration tests:

jest/no-conditional-expect rule

Screenshot 2020-11-18 at 10 45 26

Fix https://github.com/facebook/create-react-app/pull/10091/commits/4bcf5989f0c3fb45a376ebaa9814a8c73659dcfd.

jest version inconsistency

Screenshot 2020-11-18 at 11 01 20

Fix https://github.com/facebook/create-react-app/pull/10091/commits/fc4c396914d8ede89156b11990e6298b1bdaea8a.

untracked .eslintcache file

Will be fixed by https://github.com/facebook/create-react-app/pull/10177.

missing React in tests after eject

Fix https://github.com/facebook/create-react-app/pull/10091/commits/7b8c760dfe9e314fdef66efd5a1bd05eb1751091.

src regex issue

Screenshot 2020-11-18 at 13 49 40

Introduced by https://github.com/facebook/create-react-app/pull/9516. The encoded version of the optimized image ends with k=.

Fix https://github.com/facebook/create-react-app/pull/10091/commits/fe5fbeeceab69c4fbb05cc6c18da0e249ea2f2df.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/maxsbelt/fix-ci-problems