Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10140
An error occurred while fetching the assigned milestone of the selected merge_request.

update broken pace.js link in document

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/takapiro99/update-pagejs-link into master 4 years ago
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: takapiro99

I found broken link in the document, so I fixed it.


at docsaurus/docs/using-the-public-folder.md.

You want to include a small script like pace.js outside of the bundled code.

changed page.js link from https://github.hubspot.com/pace/docs/welcome/ to https://codebyzach.github.io/pace/


Thanks in advance.

Approval is optional

Merge details

  • 2 commits and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity


  • Administrator requested review from @root 4 years ago

    requested review from @root

  • Administrator requested review from @root 4 years ago

    requested review from @root

  • Administrator requested review from @root 4 years ago

    requested review from @root

  • Administrator
    Administrator @root · 4 years ago
    Author Contributor

    Created by: facebook-github-bot

    Hi @takapiro99!

    Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

    In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

    If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

  • Administrator
    Administrator @root · 4 years ago
    Author Contributor

    Created by: takapiro99

    Hi, thank you for mentioning me about Facebook CLA. I have just signed up for it.

  • Administrator added CLA Signed label 4 years ago

    added CLA Signed label

  • Administrator
    Administrator @root · 4 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

  • Administrator
    Administrator @root · 4 years ago
    Author Contributor

    Created by: tobiasbueschel

    Review: Commented

    Hi :wave:

    Thanks for your time to fix this! However, there's already a duplicate PR that was raised before that fixes the same link: https://github.com/facebook/create-react-app/pull/10096

    FYI @mrmckeb

  • Administrator
    Administrator @root · 4 years ago
    Author Contributor

    Created by: takapiro99

    there was already a duplicate PR #10096

  • Administrator closed 4 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/takapiro99/update-pagejs-link

Menu

Explore Projects Groups Snippets