Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10198

remove chalk from formatWebpackMessages

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jasonwilliams/removeChalk into master Dec 04, 2020
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: jasonwilliams

Part of https://github.com/facebook/create-react-app/issues/9994 Webpack 5 series

formatWebpackMessages.js gets pulled into the browser and potentially runs there. This causes Chalk to try and run which eventually fails.

The failure is because Webpack 5 no longer polyfills node built-ins. And Chalk uses process. The best option is to not run chalk in formatWebpackMessages.js. The text will still show in the terminal just not have a grey background, I think this is a feature worth losing compared to the errors it causes in the browser, or the large amount of refactoring everyone using this would need to do.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jasonwilliams/removeChalk