Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10265

Fix slow recompile times for existing users

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/fkirc/fix_slow_recompile_times into main Dec 18, 2020
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: fkirc

https://github.com/facebook/create-react-app/issues/9886 was a crippling performance regression that rendered react-scripts close to unusable, at least for all my projects where I was using it. Fortunately, this performance regression was fixed by the following release of eslint-webpack-plugin: https://github.com/webpack-contrib/eslint-webpack-plugin/releases/tag/v2.4.1 (otherwise I would have been forced to downgrade to react-scripts 3.X).

However, the performance regression was only fixed for new users of react-scripts, but not for existing users. The problem is that the internal dependency to eslint-webpack-plugin still accepts broken versions it its admissible range of versions. Therefore, existing users are forced to read through https://github.com/facebook/create-react-app/issues/9886 until they find out that they either have to manually bump eslint-webpack-plugin or delete their entire package-lock.json and re-install everything from scratch.

So this PR is an attempt to fix the performance regression for all users that are updating react-scripts, instead of waiting until they read through GitHub bug reports or delete their package-lock files.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/fkirc/fix_slow_recompile_times