Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10590

Upgrade eslint-webpack-plugin to fix opt-out flag

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge feature/update-eslint-optout into master Feb 21, 2021
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: mrmckeb

An update to eslint-webpack-plugin broke behaviour of the new flag (ESLINT_NO_DEV_ERRORS) that allowed users to opt-out of ESLint errors during development.

Since that time, another change was made that allows us to have similar behaviour to before.

  • https://github.com/webpack-contrib/eslint-webpack-plugin/pull/72#issuecomment-773706538
  • https://github.com/webpack-contrib/eslint-webpack-plugin/pull/85

With this new version of the plugin, we can now show errors in the terminal as errors - but as we've just rolled out the previous change, it made more sense to just fix the behaviour today. We can look at how to improve this further in future iterations.

Closes #9887 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/update-eslint-optout