Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10773

fix: patching formatWebpackMessages

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/chrisarevir/patching-formatwebpackmessage into master Apr 02, 2021
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: chrisarevir

fixes: https://github.com/facebook/create-react-app/issues/9880

Changes:

  • Message is now an object, and as such this method should be made backwards compatible
  • Adding missing dependency hinted at from the following error:
Error: Package "postcss-browser-comments@3.0.0" (via "/home/vsts/work/1/yarn-cache/v6/npm-postcss-browser-comments-3.0.0-1248d2d935fb72053c8e1f61a84a57292d9f65e9-integrity/node_modules/postcss-browser-comments/index.cjs.js") is trying to require the package "browserslist" (via "browserslist") without it being listed in its dependencies (postcss, postcss-browser-comments)

Testing strategy

Looking at the main branch, it seems like the failures on this branch are expected for the time being?

Running yarn e2e:docker yields

lerna ERR! EPUBLISHCONFLICT Cannot publish babel-plugin-named-asset-import@undefined over existing version.

as an error. If I modify the command to run e2e-kitchensink individually it works, but for the azure pipeline it is failing.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/chrisarevir/patching-formatwebpackmessage