Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10864

docs: note in Changelog that v3→v4 requires adding eslintConfig

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/mimecuvalo/patch-1 into main Apr 23, 2021
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: mimecuvalo

I came across this when trying to upgrade my company's create-react-app from v3→v4. The migration path doesn't note that you will lose ESLint capabilities unless you specify eslintConfig explicitly in your package.json going forward.

Historical progression of ESLint changes in Webpack, to clarify how we got here:

  • removal of original extend and addition to template.json: https://github.com/facebook/create-react-app/pull/9587/files
  • referencing of /base instead of /index: https://github.com/facebook/create-react-app/pull/9640/files#diff-8e25c4f6f592c1fcfc38f0d43d62cbd68399f44f494c1b60f0cf9ccd7344d697R366

This was also noticed by other developers in these bugs: https://github.com/facebook/create-react-app/issues/9791 https://github.com/facebook/create-react-app/issues/10212

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mimecuvalo/patch-1