Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10921

allow tsconfig to contain emitDeclarationOnly=true

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/entropitor/fix-no-emit into main May 05, 2021
  • Overview 17
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: entropitor

Fixes #10796 Fixes #9373 (closed) Fixes #8551

Typescript project references are a useful feature in a monorepo that allow building sub-packages incrementally and don't require a rebuild of a dependency to get up-to date type information in the editor of that dependency.

However, for it to work, some fields need to be set in the tsconfig: composite: true, incremental: true, emitDeclarationOnly: true the last one is a problem because typescript errors when there is a field for noEmit and for emitDeclarationOnly. This PR inspect the users' config, and if they already have a emitDeclarationOnly, it needs to be set to the value true and if they don't the current behaviour is kept.

I've tried copying this file to my local project's node_modules and now I can add emitDeclarationOnly without a problem (and thus without react-scripts overwriting my tsconfig)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/entropitor/fix-no-emit