Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10961

[WP5] Webpack5 update

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/raix/webpack5-update into wp5 May 14, 2021
  • Overview 6
  • Commits 62
  • Pipelines 0
  • Changes 31

Created by: raix

Webpack 5 update Includes the work listed in #9994 (closed) Replace #10656 and targeting the wp5 branch

Additional changes:

  • persistent cache
  • upgrade to dev server ´v4 (still beta)
  • terser is now included in webpack
  • comment out test except simple/kitchensink/oldnode
  • update test matrix to use node 12 + 14 (postcss-normalize requires v12 + webpack 5)

Known issues:

  • It feels like webpack emits compile twice - triggers a re print out on the screen (might be due to hook behavior change - or some of the code I removed in that area - maybe rewrite?)

Things I wanted to do but left out:

  • extract loaders/plugins etc. into separate files to make the main webpack config clean / easier to read
  • allowed domains - we should allow configuration and wildcard support imho
  • print out performance stats of the build - really hard to track / compare build speeds - eg. detecting regression
  • fix the test suite or comment out failing tests - eg. the pnp test is currently failing on master not sure if this pr. makes things better or worse
  • Maybe remove the CRA error overlay as the default webpack overlay is very similar and require less config + code?

Credit include @andriijas, @sebinsua and @jasonwilliams (let me know if I missed out on any)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/raix/webpack5-update