Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !11088

Change source map loader use to array

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/justinbhopper/node-modules-sourcemaps into main Jun 11, 2021
  • Overview 9
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: justinbhopper

This follows up #8227 (re: #issuecomment) and fixes the config for source-map-loader to use an array for the use property. This fixes compatibility with customize-cra and follows the recommended usage by source-map-loader's docs.

Without this PR, customize-cra throws the error e.use.some() is not a function, because it assumes that the use property is an array if it is truthy. This may be a normal expectation by webpack configurations, I'm not sure, but I think better compatibility is important.

I don't believe this change has any impact on anything else and just ensures best compatibility.

cc: @justingrant @mrmckeb

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/justinbhopper/node-modules-sourcemaps