Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !11164
An error occurred while fetching the assigned milestone of the selected merge_request.

Upgrade sass-loader to ^11.1.1

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/BrodaNoel/upgrade-sass-loader-dependency into main 4 years ago
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: BrodaNoel

Why

  • Fix https://github.com/facebook/create-react-app/issues/10944

I couldn't find any test to check if something is wrong. I don't see that much usage of sass-loader, which may implies that this change doesn't break anything.

The problem here is that sass-loader v11 upgrades node-sass from v5 to v6, which removes support for Node v10, which is a problem for CRA because the documentation says that it supports => 10.16

Deeper explanation in https://github.com/facebook/create-react-app/issues/10944#issuecomment-869760083

Feel free to reject this PR if I'm missing something. Everything ran too smooth. It feels weird that works on the first try

Loading
Loading

Activity


  • Administrator requested review from @root 4 years ago

    requested review from @root

  • Administrator requested review from @root 4 years ago

    requested review from @root

  • Administrator requested review from @root 4 years ago

    requested review from @root

  • Administrator requested review from @root 4 years ago

    requested review from @root

  • Administrator added CLA Signed label 4 years ago

    added CLA Signed label

  • Administrator
    Administrator @root · 3 years ago
    Author Contributor

    Created by: 3imed-jaberi

    Review: Commented

    These ready to merge when CRA decide to supported webpack >= 5.

  • Administrator
    Administrator @root · 3 years ago
    Author Contributor

    Created by: BrodaNoel

    Fixed in http://metis.lti.cs.cmu.edu:8023/facebook/create-react-app/-/merge_requests/11201

  • Administrator closed 3 years ago

    closed

  • Administrator
    Administrator @root · 3 years ago
    Author Contributor

    Created by: kahlan88

    Fixed in #11201

    Brand new install of create-react-app still has "sass-loader": "^10.0.5", in react-scripts dependencies. I am still having the issue with node-sass as a result. Any suggestions?

    I did make sure to uninstall global package first.

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/BrodaNoel/upgrade-sass-loader-dependency

Menu

Explore Projects Groups Snippets