Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !113

Pulled out app paths to separate config and added a check for required files in start script

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/christophior/master into master Jul 22, 2016
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 5

Created by: christophior

PR is still a work in progress mainly because for some reason installing the module globally on my local machine to test was not working and even installing the module from npm doesn't work so I haven't really been able to test this -_-

I keep getting a prompt saying that the create-react-app command is not found.

Anyways... I also feel like I should add some logic where the browser doesn't attempt to open if there are any missing required files, maybe don't even compile if any files are missing.

Referencing issue #96 (closed)

If someone wants to build on top of this PR feel free too as well, just leave a comment below in case I or someone else wants to continue this.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/christophior/master