Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1152

Add flow typechecking as a webpack plugin

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/rricard/integrate-flow into master Dec 04, 2016
  • Overview 67
  • Commits 75
  • Pipelines 0
  • Changes 8

Created by: rricard

cra-flow-opt

This will only run if a @flow annotation is seen in an user's file:

  • At the first @flow file found:
    • Write a .flowconfig if none exists
    • Run flow-typed install
    • Add some custom flow-typed installs (implicit jest behind react-scripts for instance)
  • When a file with an @flow comment changes during a compilation:
    • Run a flow check
    • If there are some type errors in flow: show warnings
    • If flow itself crashes: show error
  • Refactor

Followup goals:

  • Return-code-based success of the command (instead of looking for "No Errors!"
  • Detect if a global flow installation exists, if yes, check its version, if not equal to CRA's version, show a warning that compilation may be slowed down
1__yarn_start__node_
  • Ensure the first flow status run was done after complete init (especially flow-typed)
  • Add flow-typed dir to .gitignore during the first run
  • Add to end-to-end testing

Followup of a discussion in #72 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rricard/integrate-flow