Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1165

Chrome 'open tab' reuse an empty tab when possible

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/n3tr/open-chrome-use-empty-tab into master Dec 05, 2016
  • Overview 8
  • Commits 4
  • Pipelines 0
  • Changes 1

Created by: n3tr

Still WIP: need to clean up duplicated code and found some unexpected behavior (both in master and this branch)

on startscript - If there're no debugging tab (localhost:3000) open, we will try to use empty tab instead of create new one. (fixes #1157 (closed))

Test plan

To invoke script, We can use both npm/yarn start or run osascript openChrome.applescript localhost:3000 inside /packages/react-dev-utils folder .

  • No open chrome window: When chrome open with an empty tab, use the empty tab instead of create new one.
  • Chrome window with debugging tab: Reuse debugging tab.
  • Chrome window w/o debugging tab: Create new tab with url.
  • Chrome window w/o debugging tab, but have an empty tab: Use empty tab.
# Setup
npm run create-react-app my-app
cd my-app
yarn start

Test env

  • Browser: Google Chrome Version 54.0.2840.98
  • OS: macOS Sierra 10.12.1
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/n3tr/open-chrome-use-empty-tab