Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !11686

[WIP] Fix integration test teardown / cleanup and missing yarn installation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/raix/fix_integration_tests_teardown_and_cleanup into main Nov 27, 2021
  • Overview 2
  • Commits 30
  • Pipelines 0
  • Changes 5

Created by: raix

Fix tests and update execa:

  • To avoid flakyness due to race conditions: use sync version of remove letting beforeEach and afterAll
  • Update execa from v1 to v5 (v6 requires esm so downgraded to v5 for now)
  • Added test to make sure yarn is installed (making it easier to debug next time)
  • Added npm i -g yarn in github action for integration tests
  • Increased the timeout for now in yarn integration test
  • Improve run create-react-app output logging output and exit code in github action groups for better insights
  • Defer jest test result waiting for stdio to flush

Findings:

  • Sometimes yarn connectivity failes after x amount of retries

cc @iansu & @mrmckeb (We should likely squash this one if merging...)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/raix/fix_integration_tests_teardown_and_cleanup