Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1193

NPM version check for tip

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/mobinni/feature/npm-tip into master 8 years ago
  • Overview 13
  • Commits 5
  • Pipelines 0
  • Changes 2

Created by: mobinni

Implemented a version check of npm to give a soft tip during the install procedure

Loading
Loading

Activity


  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

    If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: mobinni

    @gaearon any movement on this?

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    Sorry for very long review. Requested a chance, once that is fixed it should be good review and include.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    Tagging for next release so we don't lose it.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    @mobinni Would you like to address my comment above?

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: mobinni

    @gaearon Oh sorry, I didn't seem to receive the e-mail update. Will fix!

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    Do you mind also resolving the conflict?

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: mobinni

    sure! @gaearon done :thumbsup:

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    I think this should be good. Going to land now.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Merged by: gaearon at 2017-02-24 20:25:19 UTC

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    This is now out! Thanks for contributing.

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/mobinni/feature/npm-tip