From 9c7ea2960f009a4d6de207c6e1495aedc3addcf3 Mon Sep 17 00:00:00 2001 From: joeldenning <joeldenning@gmail.com> Date: Thu, 3 Feb 2022 09:29:04 -0700 Subject: [PATCH 1/4] Support CJS file extensions --- package-lock.json | 95 ++++++++++--------- .../react-scripts/config/webpack.config.js | 15 ++- .../__snapshots__/index.test.js.snap | 5 + test/fixtures/cjs-support/index.test.js | 41 ++++++++ test/fixtures/cjs-support/package.json | 8 ++ test/fixtures/cjs-support/src/App.cjs | 36 +++++++ test/fixtures/cjs-support/src/index.js | 5 + .../__snapshots__/index.test.js.snap | 80 ++++++++++++++++ 8 files changed, 233 insertions(+), 52 deletions(-) create mode 100644 test/fixtures/cjs-support/__snapshots__/index.test.js.snap create mode 100644 test/fixtures/cjs-support/index.test.js create mode 100644 test/fixtures/cjs-support/package.json create mode 100644 test/fixtures/cjs-support/src/App.cjs create mode 100644 test/fixtures/cjs-support/src/index.js diff --git a/package-lock.json b/package-lock.json index c3624593b..317f6801b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,5 +1,5 @@ { - "name": "create-react-app-main", + "name": "create-react-app", "lockfileVersion": 2, "requires": true, "packages": { @@ -36,6 +36,7 @@ } }, "docusaurus/website": { + "name": "cra-docs", "dependencies": { "@docusaurus/core": "^2.0.0-alpha.64", "@docusaurus/preset-classic": "^2.0.0-alpha.64", @@ -11360,6 +11361,10 @@ "node": ">=10" } }, + "node_modules/cra-docs": { + "resolved": "docusaurus/website", + "link": true + }, "node_modules/cra-template": { "resolved": "packages/cra-template", "link": true @@ -28928,10 +28933,6 @@ "webpack": "3 || 4 || 5" } }, - "node_modules/website": { - "resolved": "docusaurus/website", - "link": true - }, "node_modules/websocket-driver": { "version": "0.7.4", "resolved": "https://registry.npmjs.org/websocket-driver/-/websocket-driver-0.7.4.tgz", @@ -38551,6 +38552,48 @@ "yaml": "^1.10.0" } }, + "cra-docs": { + "version": "file:docusaurus/website", + "requires": { + "@docusaurus/core": "^2.0.0-alpha.64", + "@docusaurus/preset-classic": "^2.0.0-alpha.64", + "clsx": "^1.1.1", + "react": "^16.12.0", + "react-dom": "^16.12.0" + }, + "dependencies": { + "react": { + "version": "16.14.0", + "resolved": "https://registry.npmjs.org/react/-/react-16.14.0.tgz", + "integrity": "sha512-0X2CImDkJGApiAlcf0ODKIneSwBPhqJawOa5wCtKbu7ZECrmS26NvtSILynQ66cgkT/RJ4LidJOc3bUESwmU8g==", + "requires": { + "loose-envify": "^1.1.0", + "object-assign": "^4.1.1", + "prop-types": "^15.6.2" + } + }, + "react-dom": { + "version": "16.14.0", + "resolved": "https://registry.npmjs.org/react-dom/-/react-dom-16.14.0.tgz", + "integrity": "sha512-1gCeQXDLoIqMgqD3IO2Ah9bnf0w9kzhwN5q4FGnHZ67hBm9yePzB5JJAIQCc8x3pFnNlwFq4RidZggNAAkzWWw==", + "requires": { + "loose-envify": "^1.1.0", + "object-assign": "^4.1.1", + "prop-types": "^15.6.2", + "scheduler": "^0.19.1" + } + }, + "scheduler": { + "version": "0.19.1", + "resolved": "https://registry.npmjs.org/scheduler/-/scheduler-0.19.1.tgz", + "integrity": "sha512-n/zwRWRYSUj0/3g/otKDRPMh6qv2SYMWNq85IEa8iZyAv8od9zDYpGSnpBEjNgcMNq6Scbu5KfIPxNF72R/2EA==", + "requires": { + "loose-envify": "^1.1.0", + "object-assign": "^4.1.1" + } + } + } + }, "cra-template": { "version": "file:packages/cra-template" }, @@ -51985,48 +52028,6 @@ "std-env": "^3.0.1" } }, - "website": { - "version": "file:docusaurus/website", - "requires": { - "@docusaurus/core": "^2.0.0-alpha.64", - "@docusaurus/preset-classic": "^2.0.0-alpha.64", - "clsx": "^1.1.1", - "react": "^16.12.0", - "react-dom": "^16.12.0" - }, - "dependencies": { - "react": { - "version": "16.14.0", - "resolved": "https://registry.npmjs.org/react/-/react-16.14.0.tgz", - "integrity": "sha512-0X2CImDkJGApiAlcf0ODKIneSwBPhqJawOa5wCtKbu7ZECrmS26NvtSILynQ66cgkT/RJ4LidJOc3bUESwmU8g==", - "requires": { - "loose-envify": "^1.1.0", - "object-assign": "^4.1.1", - "prop-types": "^15.6.2" - } - }, - "react-dom": { - "version": "16.14.0", - "resolved": "https://registry.npmjs.org/react-dom/-/react-dom-16.14.0.tgz", - "integrity": "sha512-1gCeQXDLoIqMgqD3IO2Ah9bnf0w9kzhwN5q4FGnHZ67hBm9yePzB5JJAIQCc8x3pFnNlwFq4RidZggNAAkzWWw==", - "requires": { - "loose-envify": "^1.1.0", - "object-assign": "^4.1.1", - "prop-types": "^15.6.2", - "scheduler": "^0.19.1" - } - }, - "scheduler": { - "version": "0.19.1", - "resolved": "https://registry.npmjs.org/scheduler/-/scheduler-0.19.1.tgz", - "integrity": "sha512-n/zwRWRYSUj0/3g/otKDRPMh6qv2SYMWNq85IEa8iZyAv8od9zDYpGSnpBEjNgcMNq6Scbu5KfIPxNF72R/2EA==", - "requires": { - "loose-envify": "^1.1.0", - "object-assign": "^4.1.1" - } - } - } - }, "websocket-driver": { "version": "0.7.4", "resolved": "https://registry.npmjs.org/websocket-driver/-/websocket-driver-0.7.4.tgz", diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index 2b1b3bbd4..951722bea 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -351,7 +351,7 @@ module.exports = function (webpackEnv) { shouldUseSourceMap && { enforce: 'pre', exclude: /@babel(?:\/|\\{1,2})runtime/, - test: /\.(js|mjs|jsx|ts|tsx|css)$/, + test: /\.(js|mjs|cjs|jsx|ts|tsx|css)$/, loader: require.resolve('source-map-loader'), }, { @@ -412,7 +412,7 @@ module.exports = function (webpackEnv) { // Process application JS with Babel. // The preset includes JSX, Flow, TypeScript, and some ESnext features. { - test: /\.(js|mjs|jsx|ts|tsx)$/, + test: /\.(js|mjs|cjs|jsx|ts|tsx)$/, include: paths.appSrc, loader: require.resolve('babel-loader'), options: { @@ -464,7 +464,7 @@ module.exports = function (webpackEnv) { // Process any JS outside of the app with Babel. // Unlike the application JS, we only compile the standard ES features. { - test: /\.(js|mjs)$/, + test: /\.(js|mjs|cjs)$/, exclude: /@babel(?:\/|\\{1,2})runtime/, loader: require.resolve('babel-loader'), options: { @@ -592,7 +592,12 @@ module.exports = function (webpackEnv) { // its runtime that would otherwise be processed through "file" loader. // Also exclude `html` and `json` extensions so they get processed // by webpacks internal loaders. - exclude: [/^$/, /\.(js|mjs|jsx|ts|tsx)$/, /\.html$/, /\.json$/], + exclude: [ + /^$/, + /\.(js|mjs|cjs|jsx|ts|tsx)$/, + /\.html$/, + /\.json$/, + ], type: 'asset/resource', }, // ** STOP ** Are you adding a new loader? @@ -764,7 +769,7 @@ module.exports = function (webpackEnv) { !disableESLintPlugin && new ESLintPlugin({ // Plugin options - extensions: ['js', 'mjs', 'jsx', 'ts', 'tsx'], + extensions: ['js', 'mjs', 'cjs', 'jsx', 'ts', 'tsx'], formatter: require.resolve('react-dev-utils/eslintFormatter'), eslintPath: require.resolve('eslint'), failOnError: !(isEnvDevelopment && emitErrorsAsWarnings), diff --git a/test/fixtures/cjs-support/__snapshots__/index.test.js.snap b/test/fixtures/cjs-support/__snapshots__/index.test.js.snap new file mode 100644 index 000000000..cbf140892 --- /dev/null +++ b/test/fixtures/cjs-support/__snapshots__/index.test.js.snap @@ -0,0 +1,5 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`can use mjs library in development 1`] = `"world"`; + +exports[`can use mjs library in production 1`] = `"world"`; diff --git a/test/fixtures/cjs-support/index.test.js b/test/fixtures/cjs-support/index.test.js new file mode 100644 index 000000000..fd2ad653c --- /dev/null +++ b/test/fixtures/cjs-support/index.test.js @@ -0,0 +1,41 @@ +const testSetup = require('../__shared__/test-setup'); + +const puppeteer = require('puppeteer'); + +test('can use cjs file in development', async () => { + const { port, done } = await testSetup.scripts.start(); + + const browser = await puppeteer.launch({ headless: true }); + try { + const page = await browser.newPage(); + await page.goto(`http://localhost:${port}/`); + await page.waitForSelector('.cjs-gql-result', { timeout: 0 }); + const output = await page.evaluate(() => { + return Array.from(document.getElementsByClassName('cjs-gql-result')).pop() + .innerHTML; + }); + expect(output).toMatchSnapshot(); + } finally { + browser.close(); + done(); + } +}); +test('can use cjs file in production', async () => { + await testSetup.scripts.build(); + const { port, done } = await testSetup.scripts.serve(); + + const browser = await puppeteer.launch({ headless: true }); + try { + const page = await browser.newPage(); + await page.goto(`http://localhost:${port}/`); + await page.waitForSelector('.cjs-gql-result', { timeout: 0 }); + const output = await page.evaluate(() => { + return Array.from(document.getElementsByClassName('cjs-gql-result')).pop() + .innerHTML; + }); + expect(output).toMatchSnapshot(); + } finally { + browser.close(); + done(); + } +}); diff --git a/test/fixtures/cjs-support/package.json b/test/fixtures/cjs-support/package.json new file mode 100644 index 000000000..8f30df607 --- /dev/null +++ b/test/fixtures/cjs-support/package.json @@ -0,0 +1,8 @@ +{ + "dependencies": { + "graphql": "^14.0.2", + "react": "latest", + "react-dom": "latest", + "serve": "^10.0.2" + } +} diff --git a/test/fixtures/cjs-support/src/App.cjs b/test/fixtures/cjs-support/src/App.cjs new file mode 100644 index 000000000..60d5e6df0 --- /dev/null +++ b/test/fixtures/cjs-support/src/App.cjs @@ -0,0 +1,36 @@ +const React = require('react'); +const { + graphql, + GraphQLSchema, + GraphQLObjectType, + GraphQLString, +} = require('graphql'); + +const schema = new GraphQLSchema({ + query: new GraphQLObjectType({ + name: 'RootQueryType', + fields: { + hello: { + type: GraphQLString, + resolve() { + return 'world'; + }, + }, + }, + }), +}); + +class App extends React.Component { + state = {}; + componentDidMount() { + graphql(schema, '{ hello }').then(({ data }) => { + this.setState({ result: data.hello }); + }); + } + render() { + const { result } = this.state; + return result ? <div className="cjs-gql-result">{result}</div> : null; + } +} + +export default App; diff --git a/test/fixtures/cjs-support/src/index.js b/test/fixtures/cjs-support/src/index.js new file mode 100644 index 000000000..b597a4423 --- /dev/null +++ b/test/fixtures/cjs-support/src/index.js @@ -0,0 +1,5 @@ +import React from 'react'; +import ReactDOM from 'react-dom'; +import App from './App'; + +ReactDOM.render(<App />, document.getElementById('root')); diff --git a/test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap b/test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap index 91042386d..fef73c699 100644 --- a/test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap +++ b/test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap @@ -113,6 +113,31 @@ Cannot find module: 'unknown-package'. Make sure this package is installed. You can install this package by running: yarn add unknown-package. +", + "stdout": "", +} +`; + +exports[`formats missing package 2`] = ` +Object { + "stderr": "npm ERR! errno 1 +npm ERR! @ build: \`react-scripts build\` +npm ERR! Exit status 1 +npm ERR! +npm ERR! Failed at the @ build script. +npm ERR! This is probably not a problem with npm. There is likely additional logging output above. + +npm ERR! A complete log of this run can be found in: +npm ERR! /Users/joeldenning/.npm/_logs/2022-02-03T16_22_12_179Z-debug.log + +> @ build /private/var/folders/kw/p55thfcs6c1gvqtt2kf0jhc00000gn/T/e5679eac6637671518cac4cc684f4358 +> react-scripts build + +Creating an optimized production build... +Failed to compile. + +Module not found: Error: Can't resolve 'unknown-package' in '/private/var/folders/kw/p55thfcs6c1gvqtt2kf0jhc00000gn/T/e5679eac6637671518cac4cc684f4358/src' + ", "stdout": "", } @@ -160,3 +185,58 @@ Attempted import error: 'bar' is not exported from './AppUnknownExport'. "stdout": "", } `; + +exports[`formats unknown export 2`] = ` +Object { + "stderr": "npm ERR! errno 1 +npm ERR! @ build: \`react-scripts build\` +npm ERR! Exit status 1 +npm ERR! +npm ERR! Failed at the @ build script. +npm ERR! This is probably not a problem with npm. There is likely additional logging output above. + +npm ERR! A complete log of this run can be found in: +npm ERR! /Users/joeldenning/.npm/_logs/2022-02-03T16_21_59_312Z-debug.log + +> @ build /private/var/folders/kw/p55thfcs6c1gvqtt2kf0jhc00000gn/T/e5679eac6637671518cac4cc684f4358 +> react-scripts build + +Creating an optimized production build... +Failed to compile. + +Attempted import error: 'bar' is not exported from './AppUnknownExport' (imported as 'bar'). + +", + "stdout": "", +} +`; + +exports[`helps when users tries to use sass 1`] = ` +Object { + "stderr": "", + "stdout": " +> @ build /private/var/folders/kw/p55thfcs6c1gvqtt2kf0jhc00000gn/T/e5679eac6637671518cac4cc684f4358 +> react-scripts build + +Creating an optimized production build... +Compiled successfully. + +File sizes after gzip: + + 43.16 kB build/static/js/main.aa544ec3.js + +The project was built assuming it is hosted at /. +You can control this with the homepage field in your package.json. + +The build folder is ready to be deployed. +You may serve it with a static server: + + npm install -g serve + serve -s build + +Find out more about deployment here: + + https://cra.link/deployment +", +} +`; -- GitLab From 33c5596890fca1e6123a19f72db535fc8df7c587 Mon Sep 17 00:00:00 2001 From: joeldenning <joeldenning@gmail.com> Date: Thu, 3 Feb 2022 09:30:11 -0700 Subject: [PATCH 2/4] Fix --- .../__snapshots__/index.test.js.snap | 5 --- test/fixtures/cjs-support/index.test.js | 41 ------------------- test/fixtures/cjs-support/package.json | 8 ---- test/fixtures/cjs-support/src/App.cjs | 36 ---------------- test/fixtures/cjs-support/src/index.js | 5 --- 5 files changed, 95 deletions(-) delete mode 100644 test/fixtures/cjs-support/__snapshots__/index.test.js.snap delete mode 100644 test/fixtures/cjs-support/index.test.js delete mode 100644 test/fixtures/cjs-support/package.json delete mode 100644 test/fixtures/cjs-support/src/App.cjs delete mode 100644 test/fixtures/cjs-support/src/index.js diff --git a/test/fixtures/cjs-support/__snapshots__/index.test.js.snap b/test/fixtures/cjs-support/__snapshots__/index.test.js.snap deleted file mode 100644 index cbf140892..000000000 --- a/test/fixtures/cjs-support/__snapshots__/index.test.js.snap +++ /dev/null @@ -1,5 +0,0 @@ -// Jest Snapshot v1, https://goo.gl/fbAQLP - -exports[`can use mjs library in development 1`] = `"world"`; - -exports[`can use mjs library in production 1`] = `"world"`; diff --git a/test/fixtures/cjs-support/index.test.js b/test/fixtures/cjs-support/index.test.js deleted file mode 100644 index fd2ad653c..000000000 --- a/test/fixtures/cjs-support/index.test.js +++ /dev/null @@ -1,41 +0,0 @@ -const testSetup = require('../__shared__/test-setup'); - -const puppeteer = require('puppeteer'); - -test('can use cjs file in development', async () => { - const { port, done } = await testSetup.scripts.start(); - - const browser = await puppeteer.launch({ headless: true }); - try { - const page = await browser.newPage(); - await page.goto(`http://localhost:${port}/`); - await page.waitForSelector('.cjs-gql-result', { timeout: 0 }); - const output = await page.evaluate(() => { - return Array.from(document.getElementsByClassName('cjs-gql-result')).pop() - .innerHTML; - }); - expect(output).toMatchSnapshot(); - } finally { - browser.close(); - done(); - } -}); -test('can use cjs file in production', async () => { - await testSetup.scripts.build(); - const { port, done } = await testSetup.scripts.serve(); - - const browser = await puppeteer.launch({ headless: true }); - try { - const page = await browser.newPage(); - await page.goto(`http://localhost:${port}/`); - await page.waitForSelector('.cjs-gql-result', { timeout: 0 }); - const output = await page.evaluate(() => { - return Array.from(document.getElementsByClassName('cjs-gql-result')).pop() - .innerHTML; - }); - expect(output).toMatchSnapshot(); - } finally { - browser.close(); - done(); - } -}); diff --git a/test/fixtures/cjs-support/package.json b/test/fixtures/cjs-support/package.json deleted file mode 100644 index 8f30df607..000000000 --- a/test/fixtures/cjs-support/package.json +++ /dev/null @@ -1,8 +0,0 @@ -{ - "dependencies": { - "graphql": "^14.0.2", - "react": "latest", - "react-dom": "latest", - "serve": "^10.0.2" - } -} diff --git a/test/fixtures/cjs-support/src/App.cjs b/test/fixtures/cjs-support/src/App.cjs deleted file mode 100644 index 60d5e6df0..000000000 --- a/test/fixtures/cjs-support/src/App.cjs +++ /dev/null @@ -1,36 +0,0 @@ -const React = require('react'); -const { - graphql, - GraphQLSchema, - GraphQLObjectType, - GraphQLString, -} = require('graphql'); - -const schema = new GraphQLSchema({ - query: new GraphQLObjectType({ - name: 'RootQueryType', - fields: { - hello: { - type: GraphQLString, - resolve() { - return 'world'; - }, - }, - }, - }), -}); - -class App extends React.Component { - state = {}; - componentDidMount() { - graphql(schema, '{ hello }').then(({ data }) => { - this.setState({ result: data.hello }); - }); - } - render() { - const { result } = this.state; - return result ? <div className="cjs-gql-result">{result}</div> : null; - } -} - -export default App; diff --git a/test/fixtures/cjs-support/src/index.js b/test/fixtures/cjs-support/src/index.js deleted file mode 100644 index b597a4423..000000000 --- a/test/fixtures/cjs-support/src/index.js +++ /dev/null @@ -1,5 +0,0 @@ -import React from 'react'; -import ReactDOM from 'react-dom'; -import App from './App'; - -ReactDOM.render(<App />, document.getElementById('root')); -- GitLab From 7438b5f925c698d1d641113308c8f33c6d9e0cbe Mon Sep 17 00:00:00 2001 From: joeldenning <joeldenning@gmail.com> Date: Thu, 3 Feb 2022 09:34:27 -0700 Subject: [PATCH 3/4] Undo package-lock.json changes --- package-lock.json | 95 +++++++++++++++++++++++------------------------ 1 file changed, 47 insertions(+), 48 deletions(-) diff --git a/package-lock.json b/package-lock.json index 317f6801b..c3624593b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,5 +1,5 @@ { - "name": "create-react-app", + "name": "create-react-app-main", "lockfileVersion": 2, "requires": true, "packages": { @@ -36,7 +36,6 @@ } }, "docusaurus/website": { - "name": "cra-docs", "dependencies": { "@docusaurus/core": "^2.0.0-alpha.64", "@docusaurus/preset-classic": "^2.0.0-alpha.64", @@ -11361,10 +11360,6 @@ "node": ">=10" } }, - "node_modules/cra-docs": { - "resolved": "docusaurus/website", - "link": true - }, "node_modules/cra-template": { "resolved": "packages/cra-template", "link": true @@ -28933,6 +28928,10 @@ "webpack": "3 || 4 || 5" } }, + "node_modules/website": { + "resolved": "docusaurus/website", + "link": true + }, "node_modules/websocket-driver": { "version": "0.7.4", "resolved": "https://registry.npmjs.org/websocket-driver/-/websocket-driver-0.7.4.tgz", @@ -38552,48 +38551,6 @@ "yaml": "^1.10.0" } }, - "cra-docs": { - "version": "file:docusaurus/website", - "requires": { - "@docusaurus/core": "^2.0.0-alpha.64", - "@docusaurus/preset-classic": "^2.0.0-alpha.64", - "clsx": "^1.1.1", - "react": "^16.12.0", - "react-dom": "^16.12.0" - }, - "dependencies": { - "react": { - "version": "16.14.0", - "resolved": "https://registry.npmjs.org/react/-/react-16.14.0.tgz", - "integrity": "sha512-0X2CImDkJGApiAlcf0ODKIneSwBPhqJawOa5wCtKbu7ZECrmS26NvtSILynQ66cgkT/RJ4LidJOc3bUESwmU8g==", - "requires": { - "loose-envify": "^1.1.0", - "object-assign": "^4.1.1", - "prop-types": "^15.6.2" - } - }, - "react-dom": { - "version": "16.14.0", - "resolved": "https://registry.npmjs.org/react-dom/-/react-dom-16.14.0.tgz", - "integrity": "sha512-1gCeQXDLoIqMgqD3IO2Ah9bnf0w9kzhwN5q4FGnHZ67hBm9yePzB5JJAIQCc8x3pFnNlwFq4RidZggNAAkzWWw==", - "requires": { - "loose-envify": "^1.1.0", - "object-assign": "^4.1.1", - "prop-types": "^15.6.2", - "scheduler": "^0.19.1" - } - }, - "scheduler": { - "version": "0.19.1", - "resolved": "https://registry.npmjs.org/scheduler/-/scheduler-0.19.1.tgz", - "integrity": "sha512-n/zwRWRYSUj0/3g/otKDRPMh6qv2SYMWNq85IEa8iZyAv8od9zDYpGSnpBEjNgcMNq6Scbu5KfIPxNF72R/2EA==", - "requires": { - "loose-envify": "^1.1.0", - "object-assign": "^4.1.1" - } - } - } - }, "cra-template": { "version": "file:packages/cra-template" }, @@ -52028,6 +51985,48 @@ "std-env": "^3.0.1" } }, + "website": { + "version": "file:docusaurus/website", + "requires": { + "@docusaurus/core": "^2.0.0-alpha.64", + "@docusaurus/preset-classic": "^2.0.0-alpha.64", + "clsx": "^1.1.1", + "react": "^16.12.0", + "react-dom": "^16.12.0" + }, + "dependencies": { + "react": { + "version": "16.14.0", + "resolved": "https://registry.npmjs.org/react/-/react-16.14.0.tgz", + "integrity": "sha512-0X2CImDkJGApiAlcf0ODKIneSwBPhqJawOa5wCtKbu7ZECrmS26NvtSILynQ66cgkT/RJ4LidJOc3bUESwmU8g==", + "requires": { + "loose-envify": "^1.1.0", + "object-assign": "^4.1.1", + "prop-types": "^15.6.2" + } + }, + "react-dom": { + "version": "16.14.0", + "resolved": "https://registry.npmjs.org/react-dom/-/react-dom-16.14.0.tgz", + "integrity": "sha512-1gCeQXDLoIqMgqD3IO2Ah9bnf0w9kzhwN5q4FGnHZ67hBm9yePzB5JJAIQCc8x3pFnNlwFq4RidZggNAAkzWWw==", + "requires": { + "loose-envify": "^1.1.0", + "object-assign": "^4.1.1", + "prop-types": "^15.6.2", + "scheduler": "^0.19.1" + } + }, + "scheduler": { + "version": "0.19.1", + "resolved": "https://registry.npmjs.org/scheduler/-/scheduler-0.19.1.tgz", + "integrity": "sha512-n/zwRWRYSUj0/3g/otKDRPMh6qv2SYMWNq85IEa8iZyAv8od9zDYpGSnpBEjNgcMNq6Scbu5KfIPxNF72R/2EA==", + "requires": { + "loose-envify": "^1.1.0", + "object-assign": "^4.1.1" + } + } + } + }, "websocket-driver": { "version": "0.7.4", "resolved": "https://registry.npmjs.org/websocket-driver/-/websocket-driver-0.7.4.tgz", -- GitLab From dfb4f9fc39eb606105214e96d496fd4c570eb294 Mon Sep 17 00:00:00 2001 From: joeldenning <joeldenning@gmail.com> Date: Thu, 3 Feb 2022 09:34:57 -0700 Subject: [PATCH 4/4] Undo changes --- .../__snapshots__/index.test.js.snap | 80 ------------------- 1 file changed, 80 deletions(-) diff --git a/test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap b/test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap index fef73c699..91042386d 100644 --- a/test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap +++ b/test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap @@ -113,31 +113,6 @@ Cannot find module: 'unknown-package'. Make sure this package is installed. You can install this package by running: yarn add unknown-package. -", - "stdout": "", -} -`; - -exports[`formats missing package 2`] = ` -Object { - "stderr": "npm ERR! errno 1 -npm ERR! @ build: \`react-scripts build\` -npm ERR! Exit status 1 -npm ERR! -npm ERR! Failed at the @ build script. -npm ERR! This is probably not a problem with npm. There is likely additional logging output above. - -npm ERR! A complete log of this run can be found in: -npm ERR! /Users/joeldenning/.npm/_logs/2022-02-03T16_22_12_179Z-debug.log - -> @ build /private/var/folders/kw/p55thfcs6c1gvqtt2kf0jhc00000gn/T/e5679eac6637671518cac4cc684f4358 -> react-scripts build - -Creating an optimized production build... -Failed to compile. - -Module not found: Error: Can't resolve 'unknown-package' in '/private/var/folders/kw/p55thfcs6c1gvqtt2kf0jhc00000gn/T/e5679eac6637671518cac4cc684f4358/src' - ", "stdout": "", } @@ -185,58 +160,3 @@ Attempted import error: 'bar' is not exported from './AppUnknownExport'. "stdout": "", } `; - -exports[`formats unknown export 2`] = ` -Object { - "stderr": "npm ERR! errno 1 -npm ERR! @ build: \`react-scripts build\` -npm ERR! Exit status 1 -npm ERR! -npm ERR! Failed at the @ build script. -npm ERR! This is probably not a problem with npm. There is likely additional logging output above. - -npm ERR! A complete log of this run can be found in: -npm ERR! /Users/joeldenning/.npm/_logs/2022-02-03T16_21_59_312Z-debug.log - -> @ build /private/var/folders/kw/p55thfcs6c1gvqtt2kf0jhc00000gn/T/e5679eac6637671518cac4cc684f4358 -> react-scripts build - -Creating an optimized production build... -Failed to compile. - -Attempted import error: 'bar' is not exported from './AppUnknownExport' (imported as 'bar'). - -", - "stdout": "", -} -`; - -exports[`helps when users tries to use sass 1`] = ` -Object { - "stderr": "", - "stdout": " -> @ build /private/var/folders/kw/p55thfcs6c1gvqtt2kf0jhc00000gn/T/e5679eac6637671518cac4cc684f4358 -> react-scripts build - -Creating an optimized production build... -Compiled successfully. - -File sizes after gzip: - - 43.16 kB build/static/js/main.aa544ec3.js - -The project was built assuming it is hosted at /. -You can control this with the homepage field in your package.json. - -The build folder is ready to be deployed. -You may serve it with a static server: - - npm install -g serve - serve -s build - -Find out more about deployment here: - - https://cra.link/deployment -", -} -`; -- GitLab