Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !12051

Fix missing build error file paths

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/WesCossick/fix-missing-build-error-paths into main Feb 11, 2022
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: WesCossick

Fixes #12043.

Due to this commit, the file path indicating where a TypeScript build error came from was lost. See this comment for a comparison of CRA v5 vs v4.

This is a very problematic bug, with an easy fix.

Before

Creating an optimized production build...
Failed to compile.

TS6133: 'React' is declared but its value is never read.
    1 | // Imports
  > 2 | import React from 'react';
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^
    3 | import { render } from '@testing-library/react';
    4 | import Settings from './';
    5 | import { MemoryRouter } from 'react-router-dom';

After

Creating an optimized production build...
Failed to compile.

Error in src/components/sections/settings/index.test.tsx:2:1
TS6133: 'React' is declared but its value is never read.
    1 | // Imports
  > 2 | import React from 'react';
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^
    3 | import { render } from '@testing-library/react';
    4 | import Settings from './';
    5 | import { MemoryRouter } from 'react-router-dom';
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/WesCossick/fix-missing-build-error-paths