Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !12086

Updated tsconfig.json:modify the compilation target from es5 to es6

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/puxiao/main into main Feb 22, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: puxiao

I ran into a problem yesterday, as follows:

type XxxType = 'aaa' | 'bbb' | 'ccc'
interface Xxx {
    type: XxxType
}
interface MyXxx {
    name: string
    xxx: Xxx
}
interface MyObj {
    arr: Iterable<MyXxx>
}

const myObj: MyObj = {
    arr: [ { name: 'aaa', xxx: { type: 'aaa' } } ]
}

emm...

Type '{ name: string; xxx: { type: string; }; }[]' is not assignable to type 'Iterable<MyXxx>'.
...
Type 'string' is not assignable to type 'XxxType'. ts[2322]

It's maddening and unbelievable.

I think there is nothing wrong with what I wrote.


Finally, I found the reason.

{
  "compilerOptions": {
-    "target": "es5",
+    "target": "es6",
    ...
  }
}

ES6 also called ES2015


ES5 seems like a very long time ago. So I suggest changing the default ES5 to ES6.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/puxiao/main