Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1229

Disable jest watch mode when --coverage flag is present [#1207]

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/BenoitAverty/master into master Dec 10, 2016
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: BenoitAverty

This PR adds the enhancement described in #1207 (closed).

I just added this condition to the addition of the '--watch' flag in the test script. I tested this on my computer and it seems to do the trick, i'm guessing the rest is handled by Jest (make all the tests run when not in watch mode, versus only run tests modified since last commit when watch mode is active).

If there's something I forgot, please let me know.

Also I ran the tasks/e2e.sh script, and it hangs on line 181 npm run test -- --watch=no because it does, in fact, run in watch mode. You have to press 'q' for the script to continue. Is this normal or a regression I introduced ? This seems to be true even on master...

Finally, is there something to add to test the new behavior?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/BenoitAverty/master