Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !12351

Define process.platform in react-error-overlay's iframe bundle

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/maxdavidson/fix-missing-process-in-error-overlay-iframe into main May 02, 2022
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: maxdavidson

react-error-overlay is broken since 6.0.10, due to the upgrades in #11624 transitively bring in chalk into the react-error-overlay iframe bundle.

chalk calls process.platform which is not available in browsers, making the code crash. This has side effects of causing the iframe overlay to not disappear, preventing the user from being able to click on anything.

This is a quick fix that overrides process.platform, to make it not crash.

Fixes: #11773, #12064, #12212 Duplicate of #12121?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/maxdavidson/fix-missing-process-in-error-overlay-iframe