Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !12385

react-dev-utils: fix openBrowser

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/dlech/patch-1 into main May 11, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: dlech

The "open" package had a breaking change in v8: https://github.com/sindresorhus/open/commit/8c00bd89d4604f9ec70568dce466a2162b30bcb1

The react-dev-utils dependency on this package was updated in https://github.com/facebook/create-react-app/commit/3afbbc0ab922fb982bb275ccb3fe5beecdf5f889 without taking this into account.

This updates the call to open() in openBrowser.js to use the new options properties.

Without this change, the BROWSER environment variable is ignored when running yarn start.

This has been tested by manually editing my local install with the same change.

Fixes #12275

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dlech/patch-1