Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !12391

fix: production mode cache invalid

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/zenotsai/mr/main/fix_build_cache into main 3 years ago
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: zenotsai

Why

react-scripts/scripts/build.js does not call compiler.close (here compiler starts to store cache)

refer: https://github.com/webpack/webpack/issues/12345

Compare
  • version 1
    9e831ce4
    2 years ago

  • main (HEAD)

and
  • latest version
    9e831ce4
    1 commit, 2 years ago

  • version 1
    9e831ce4
    1 commit, 2 years ago

1 file
+ 5
- 0

    Preferences

    File browser
    Compare changes
packages/react-scripts/scripts/build.js
+ 5
- 0
  • View file @ df9eee3e

  • Edit in single-file editor

  • Open in Web IDE


@@ -214,6 +214,11 @@ function build(previousFileSizes) {
return resolve(resolveArgs);
});
}).then((res) => {
compiler.close((closeErr) => {
closeErr && console.error(closeErr);
});
return res;
});
}
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
CLA Signed tag: underlying tools
2
CLA Signed tag: underlying tools
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: facebook/create-react-app!9526
Source branch: github/fork/zenotsai/mr/main/fix_build_cache

Menu

Explore Projects Groups Snippets