Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !12407

Upgrade address to fix urls.lanUrlForConfig not getting defined

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/joey-laminar/patch-1 into main May 16, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: joey-laminar

When using node 18 the old address library is unable to resolve ip addresses. This causes running a local server to fail with

Invalid options object. Dev Server has been initialized using an options object that does not match the API schema.
 - options.allowedHosts[0] should be a non-empty string.

similarly to the issue reported in #11762

The latest version of address fixes this issue.

This will also relieve part of the pain that #11877 tries to solve (although that PR is still necessary in case the address resolution fails for other reasons).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/joey-laminar/patch-1