Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !12568

Don't self-close void elements in template HTMLs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/atesgoral/void-elements into main Jul 04, 2022
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: atesgoral

Void elements (<meta>, <link>) should not be self-closing. These templates are not XHTML or JSX, but HTML5. And in HTML5, the end slash has no effect.

While they work fine (since browsers are notoriously forgiving), it would be nice for CRA templates to be exemplary and stick to standards/conventions as closely as possible because of their immense proliferation + teaching power.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/atesgoral/void-elements