Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !13011

Make CSS processing the same in dev and prod

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Clemens Wolff requested to merge github/fork/c-w/remove-style-loader into main Feb 11, 2023
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

This pull request is a revival of https://github.com/facebook/create-react-app/pull/8148 given that react-scripts is now on webpack 5 and MiniCssExtractPlugin now supports hot reloading.

With this pull request, we can make CSS processing the same between dev and prod builds which helps in avoiding hard to debug issues where some CSS works fine locally but doesn't work when deployed due to ordering conflicts or similar. It's a problem I ran into recently and currently have to work-around by manually patching react-scripts in postinstall.

Tagging @andriijas @elektronik2k5 @vatz88 who participated in the original pull request.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/c-w/remove-style-loader