Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !131

Show system notifications for errors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/goshacmd/error-notify into master 9 years ago
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: goshacmd

Uses webpack-notifier under the hood. No setup necessary. Supports Notification Center on OS X, Toaster on Windows 8 and later. Falls back to Growl if present.

(https://github.com/mikaelbr/node-notifier/blob/master/DECISION_FLOW.md)

Ref #89 (closed).

Notifications look like this:

screen shot 2016-07-23 at 12 42 54 pm

for this error:

Error in ./src/App.js
Syntax error: /Users/goshakkk/Projects/oss/create-react-app/demo/src/App.js: Unexpected token (11:38)
   9 |         <div className="App-header">
  10 |           <img src={logo} className="App-logo" alt="logo" />
> 11 |           <h2>Welcome to React z</h2><<div
     |                                       ^
  12 |         </div>
  13 |         <p className="App-intro">
  14 |           To get started, edit <code>src/App.js</code> and save to reload.
 @ ./src/index.js 11:11-27
  • Possible to supply a custom image to webpack-notifier, could be React logo. Considerations: eject will have to copy the logo as well. Might be okay though.

  • Custom title is supported by webpack-notifier. "React" might be a bit too broad, "React Scripts" or "Create React App" or "React CLI" might be better.

  • Custom error formatter is not supported, plus terminal coloring artifacts are present ([4m). Not currently possible to supply a custom formatter to webpack-notifier. Ideally the message should have been

    Error: ./App.js Unexpected token (11:38)

    Full path & parts of stack trace seem irrelevant for the notification. Error message is much more informative.

Compare
  • master (base)

and
  • latest version
    7112b525
    1 commit, 2 years ago

2 files
+ 5
- 2

    Preferences

    File browser
    Compare changes
con‎fig‎
webpack.co‎nfig.dev.js‎ +3 -1
packag‎e.json‎ +2 -1
config/webpack.config.dev.js
+ 3
- 1
  • View file @ 7112b525


@@ -11,6 +11,7 @@ var path = require('path');
@@ -11,6 +11,7 @@ var path = require('path');
var autoprefixer = require('autoprefixer');
var autoprefixer = require('autoprefixer');
var webpack = require('webpack');
var webpack = require('webpack');
var HtmlWebpackPlugin = require('html-webpack-plugin');
var HtmlWebpackPlugin = require('html-webpack-plugin');
 
var WebpackNotifierPlugin = require('webpack-notifier');
// TODO: hide this behind a flag and eliminate dead code on eject.
// TODO: hide this behind a flag and eliminate dead code on eject.
// This shouldn't be exposed to the user.
// This shouldn't be exposed to the user.
@@ -99,6 +100,7 @@ module.exports = {
@@ -99,6 +100,7 @@ module.exports = {
}),
}),
new webpack.DefinePlugin({ 'process.env.NODE_ENV': '"development"' }),
new webpack.DefinePlugin({ 'process.env.NODE_ENV': '"development"' }),
// Note: only CSS is currently hot reloaded
// Note: only CSS is currently hot reloaded
new webpack.HotModuleReplacementPlugin()
new webpack.HotModuleReplacementPlugin(),
 
new WebpackNotifierPlugin(),
]
]
};
};
package.json
+ 2
- 1
  • View file @ 7112b525


@@ -53,7 +53,8 @@
@@ -53,7 +53,8 @@
"style-loader": "0.13.1",
"style-loader": "0.13.1",
"url-loader": "0.5.7",
"url-loader": "0.5.7",
"webpack": "1.13.1",
"webpack": "1.13.1",
"webpack-dev-server": "1.14.1"
"webpack-dev-server": "1.14.1",
 
"webpack-notifier": "1.3.0"
},
},
"devDependencies": {
"devDependencies": {
"bundle-deps": "^1.0.0",
"bundle-deps": "^1.0.0",
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
CLA Signed
1
CLA Signed
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!131
Source branch: github/fork/goshacmd/error-notify

Menu

Explore Projects Groups Snippets