Created by: robbiedigital
handleSuccess function in react-dev-utils/webpackHotDevClient.js does not run for message.type of 'still-ok'. added 'still-ok' to the switch statement so in can reload the window and appropriately clear error messages.
Activity
Created by: facebook-github-bot
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!
If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.
Created by: robbiedigital
I was writing a plugin that emitted errors to webpack on fail. However on success the compilation.errors object is not touched (left empty) so webpack emits a 'still-ok' status. Which webpackHotDevClient does not know how to handle.
You can see the code for 'still-ok' status at https://github.com/webpack/webpack-dev-server/blob/master/lib/Server.js#L467
