Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1433

Modularise scripts

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/djgrant/enhancement/modularise-scripts into master Jan 23, 2017
  • Overview 15
  • Commits 8
  • Pipelines 0
  • Changes 9

Created by: djgrant

Following the discussion and for reasons mentioned in #1431 (closed), this PR aims to refactor the webpack abstractions found in the start script out into their own utility modules.

I've aimed to maintain the general narrative of the script by keeping the running of methods in the script and using callback to eliminate interweaving.

Summary of changes

/config
  + webpackDevServer.config.js
/scripts
  /utils
     + addWebpackMiddleware.js
     ~ createJestConfig.js
     + createWebpackCompiler.js
  ~ eject.js
  ~ start.js 
  • All files found in specified folders get copied to the app directory on eject
  • Except files flagged with a // @remove-file-on-eject comment, which will be skipped i.e. scripts/eject.js & scripts/utils/createJestConfig.js
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/djgrant/enhancement/modularise-scripts