Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1470

E2e jsdom fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/EnoahNetzach/e2e-jsdom-fix into master Jan 30, 2017
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 20

Created by: EnoahNetzach

@Timer @tuchk4

The trick was probably to add the event listener earlier, and to gain control on when to close document.

Now we don't have event differences between E2E_FILE and E2E_URL in this regard, and don't have to wait/poll for when the feature is fully loaded.


@gaearon any insight on why calling

this.setState({ users }, () => this.done())

works, but

this.setState({ users }, this.done)

doesn't (@here)?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/EnoahNetzach/e2e-jsdom-fix