From 93d1ee47c1a4de1c09ff4d380084000eee0b95c8 Mon Sep 17 00:00:00 2001
From: Brian Ng <bng412@gmail.com>
Date: Wed, 15 Feb 2017 14:18:34 -0600
Subject: [PATCH 1/2] Make sure prod babel plugins are actually included
---
packages/babel-preset-react-app/index.js | 30 +++++++++++++-----------
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/packages/babel-preset-react-app/index.js b/packages/babel-preset-react-app/index.js
index a81fbdb99..53d8c7dbc 100644
--- a/packages/babel-preset-react-app/index.js
+++ b/packages/babel-preset-react-app/index.js
@@ -87,6 +87,21 @@ if (env === 'test') {
plugins: plugins
};
} else {
+ plugins.push.apply(plugins, [
+ // function* () { yield 42; yield 43; }
+ [require.resolve('babel-plugin-transform-regenerator'), {
+ // Async functions are converted to generators by babel-preset-latest
+ async: false
+ }]
+ ]);
+
+ if (env === 'production') {
+ // Optimization: hoist JSX that never changes out of render()
+ plugins.push.apply(plugins, [
+ require.resolve('babel-plugin-transform-react-constant-elements')
+ ]);
+ }
+
module.exports = {
presets: [
// Latest stable ECMAScript features
@@ -98,19 +113,6 @@ if (env === 'test') {
// JSX, Flow
require.resolve('babel-preset-react')
],
- plugins: plugins.concat([
- // function* () { yield 42; yield 43; }
- [require.resolve('babel-plugin-transform-regenerator'), {
- // Async functions are converted to generators by babel-preset-latest
- async: false
- }],
- ])
+ plugins: plugins
};
-
- if (env === 'production') {
- // Optimization: hoist JSX that never changes out of render()
- plugins.push.apply(plugins, [
- require.resolve('babel-plugin-transform-react-constant-elements')
- ]);
- }
}
--
GitLab
From ada3b2f6af058071c43a9fcf887444819a262555 Mon Sep 17 00:00:00 2001
From: Brian Ng <bng412@gmail.com>
Date: Wed, 15 Feb 2017 14:31:12 -0600
Subject: [PATCH 2/2] Drop adding transform-es2015-parameters in test env
---
packages/babel-preset-react-app/index.js | 7 -------
1 file changed, 7 deletions(-)
diff --git a/packages/babel-preset-react-app/index.js b/packages/babel-preset-react-app/index.js
index 53d8c7dbc..80bb342b2 100644
--- a/packages/babel-preset-react-app/index.js
+++ b/packages/babel-preset-react-app/index.js
@@ -66,13 +66,6 @@ if (env === 'development' || env === 'test') {
}
if (env === 'test') {
- plugins.push.apply(plugins, [
- // We always include this plugin regardless of environment
- // because of a Babel bug that breaks object rest/spread without it:
- // https://github.com/babel/babel/issues/4851
- require.resolve('babel-plugin-transform-es2015-parameters')
- ]);
-
module.exports = {
presets: [
// ES features necessary for user's Node version
--
GitLab