Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1662

add project name validation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/johann-sonntagbauer/projectname into master Feb 27, 2017
  • Overview 12
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: johann-sonntagbauer

Could be a potential fix for #1649 (closed)

The main idea is to validate the project name to meet the npm specification. If the validation fails detailed error information is provided to resolve the issue.

$ node ./create-react-app/packages/create-react-app/index.js "   asdf:asdf asdfasdf asdföjk asdlöfj alösdfjk aölsdfkjalö sdfjkalösdkfj öalsdkfjalös dfdklö jasdlöfj asödlfjasl
ö dfkjaslödfkj asdlöfjkaslöd fkjasdlöfjaslö dfjasöldfjasöldfjk aösdlfj aölsdfjasdf asdf SAD asdfasdfasdf asdfasdfa sdfasdäfk äasdfjklö asdfjlö aksdjfölasjd fölaksdfjölasj dfö
laksdfj  DSD~"
The project name    asdf:asdf asdfasdf asdföjk asdlöfj alösdfjk aölsdfkjalö sdfjkalösdkfj öalsdkfjalös dfdklö jasdlöfj asödlfjaslö dfkjaslödfkj asdlöfjkaslöd fkjasdlöfjaslö dfjasöldfjasöldfjk aösdlfj aölsdfjasdf asdf SAD asdfasdfasdf asdfasdfa sdfasdäfk äasdfjklö asdfjlö aksdjfölasjd fölaksdfjölasj dfölaksdfj  DSD~ is not valid:
  name cannot contain leading or trailing spaces
  name can only contain URL-friendly characters
  name can no longer contain more than 214 characters
  name can no longer contain capital letters
  name can no longer contain special characters ("~'!()*")
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/johann-sonntagbauer/projectname